[Experimental] Add refactorWithScope() method to get typed Scope easily and required #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-refactor-with-scope
branch
from
c6a0f29 to
78da569
Compare
samsonasik
reviewed
May 4, 2022
TomasVotruba
force-pushed
the
tv-refactor-with-scope
branch
from
ad667ba to
88240e1
Compare
TomasVotruba
commented
May 4, 2022
Comment on lines
+78
to
+82
| if ($node instanceof Foreach_) { | ||
| // decorate value as well | ||
| $node->valueVar->setAttribute(AttributeKey::SCOPE, $mutatingScope); | ||
| } | ||
|
|
There was a problem hiding this comment.
@ondrejmirtes Hi Ondra, btw, we had some weird bug with missing scope. I though it's Rector creating new nodes that do not have it, but in the end it showed the Foreach->var has no Scope. The hotfix is to add it manually here.
Is that on purpose to walk around something or just missing?
…od, return new nodes directly as array
TomasVotruba
force-pushed
the
tv-refactor-with-scope
branch
2 times, most recently
from
3f48473 to
6b244cd
Compare
TomasVotruba
force-pushed
the
tv-refactor-with-scope
branch
from
aa295ed to
d4f535e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.