Fix PHPStan parser for different PHP version parsing

[TomasVotruba]

Ref rectorphp/rector#6970

[samsonasik]

@TomasVotruba It seems if it called multiple time, the changes keep happen:

bin/rector p vendor/clue/ndjson-react/src/Decoder.php -c build/config/config-downgrade-parallel.php -n --clear-cache --debug

try call multiple times, and it keep adding diff, which should not.

[samsonasik]

It called multiple time, make multipel changes:

bin/rector process vendor/clue/ndjson-react/src/Decoder.php -c build/config/config-downgrade-parallel.php --clear-cache --debug

             if ($this->options === 0) {
-                $data = \json_decode($data, ($this->assoc === null ?: $this->assoc) === null ?: ($this->assoc === null ?: $this->assoc), $this->depth);
+                $data = \json_decode($data, (($this->assoc === null ?: $this->assoc) === null ?: ($this->assoc === null ?: $this->assoc)) === null ?: (($this->assoc === null ?: $this->assoc) === null ?: ($this->assoc === null ?: $this->assoc)), $this->depth);
             } else {
-                $data = \json_decode($data, ($this->assoc === null ?: $this->assoc) === null ?: ($this->assoc === null ?: $this->assoc), $this->depth, $this->options);
+                $data = \json_decode($data, (($this->assoc === null ?: $this->assoc) === null ?: ($this->assoc === null ?: $this->assoc)) === null ?: (($this->assoc === null ?: $this->assoc) === null ?: ($this->assoc === null ?: $this->assoc)), $this->depth, $this->options);

[TomasVotruba]

Indeed, the scope is not refreshed so the type is the same. I'll check it 👍

[samsonasik]

@TomasVotruba the vendor/clue/ndjson-react/src/Decoder.php should not be changed since the $this->assoc is always filled at constructor, and always be bool.

[samsonasik]

This change is invalid:

1) vendor/clue/ndjson-react/src/Decoder.php:108

    ---------- begin diff ----------
@@ @@

             // decode data with options given in ctor
             if ($this->options === 0) {
-                $data = \json_decode($data, $this->assoc, $this->depth);
+                $data = \json_decode($data, $this->assoc === null ?: $this->assoc, $this->depth);
             } else {
-                $data = \json_decode($data, $this->assoc, $this->depth, $this->options);
+                $data = \json_decode($data, $this->assoc === null ?: $this->assoc, $this->depth, $this->options);
             }

             // abort stream if decoding failed
    ----------- end diff -----------

Applied rules:
 * DowngradeJsonDecodeNullAssociativeArgRector (https://3v4l.org/b1mA6)

since $this->assoc always filled by construct, and always be bool for @param bool, while it technically possible to provide non bool, but this change cause innnecessary change.

[TomasVotruba]

@samsonasik I've tried few parser.neon modifications, but no useful result that would not break something else.
Let's revert for now to last working modification. Thanks for feedbacks 👍