Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parser] use simple parser to remove unsupported code #1789

Merged
merged 1 commit into from Feb 9, 2022

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Feb 9, 2022

Mirror to fix in PHPStan phpstan/phpstan-src@433511a

Closes rectorphp/rector#6970

@samsonasik
Copy link
Member

Can skipped ReservedFnFunctionRector test be enabled with it?

$this->markTestSkipped('Requires tweaked PHP Parser to verify `fn` as valid function to simulate php <7.4');

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Feb 9, 2022

ReservedFnFunctionRector

I've just tried it and answer is... no.
It would require to run tests on version when the fn was not reserved keyword.

@TomasVotruba TomasVotruba enabled auto-merge (squash) February 9, 2022 00:57
@TomasVotruba TomasVotruba merged commit 94ef798 into main Feb 9, 2022
@TomasVotruba TomasVotruba deleted the tv-use-simple-parser branch February 9, 2022 00:59
@TomasVotruba
Copy link
Member Author

It didn't resolve the issue yet. I'll check it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants