[Parallel] Fix system errors expected an instance of SystemError but got string

[zingimmick]

Fixes: rectorphp/rector#6901

[TomasVotruba]

The fix should happen in the other direction. Where the error message is string, should be object.

[zingimmick]

The fix should happen in the other direction. Where the error message is string, should be object.

@TomasVotruba I tried to convert it to an object, but the required argument $relativeFilePath is missing.

The location of the code where the error message is string:

rector-src/packages/Parallel/Application/ParallelFileProcessor.php

Line 169 in 34c61ba

$systemErrors[] = 'System error: ' . $jsonError;

rector-src/packages/Parallel/Application/ParallelFileProcessor.php

Line 214 in 34c61ba

$systemErrors[] = 'Child process error: ' . $stdErr;

rector-src/packages/Parallel/Application/ParallelFileProcessor.php

Lines 224 to 227 in 34c61ba

	$systemErrors[] = sprintf(
	'Reached system errors count limit of %d, exiting...',
	self::SYSTEM_ERROR_COUNT_LIMIT
	);

[TomasVotruba]

but the required argument $relativeFilePath is missing.

It could be either optional or with with AbstractSystemError. How would that work?

The reason is we should work with strict objects, moreover when we juggle around json data in paralle processes. Only that way we can control what data types are on I/O. When we start to send strings, it could be anything, from error message, to file content, and we'll be unable to resolve what we work with.

Jsonable value objects makes sure we know the types all the time.

[zingimmick]

The reason is we should work with strict objects, moreover when we juggle around json data in paralle processes. Only that way we can control what data types are on I/O. When we start to send strings, it could be anything, from error message, to file content, and we'll be unable to resolve what we work with.

I see. I'll try the optional first and see what happens.

[zingimmick]

This is what an error message looks like with relativeFilePath optional.

 [ERROR] Could not process "" file, due to:                                                                             
         "Reached system errors count limit of 20, exiting...".    

[TomasVotruba]

How should we rephrase it?

[staabm]

Could you type this array, so phpstan would error when strings are pushed onto the array?

[zingimmick]

Add a type to this array, but phpstan does not error when a string is pushed into the array. 🤔

[zingimmick]

It's not supported yet. phpstan/phpstan#3269, phpstan/phpstan#3703

[zingimmick]

How should we rephrase it?

How about

 [ERROR] Could not process some files, due to:                                                                             
         "Reached system errors count limit of 20, exiting...".    

[TomasVotruba]

@zingimmick Sounds good 👍

[TomasVotruba]

Thank you 👍

I'm merging this now, so we can fix important bug that blocks us at the moment. Feel free to send PR with better wording.