Revert Add class-string typehint to MethodCallRename (#2726)

This reverts commit f99f19c.
rectorphp · Aug 6, 2022 · efbf03b · efbf03b
1 parent f4bc6c3
commit efbf03b
Show file tree

Hide file tree

Showing 28 changed files with 1 addition and 79 deletions.
diff --git a/rules/Arguments/ValueObject/ArgumentAdder.php b/rules/Arguments/ValueObject/ArgumentAdder.php
@@ -11,7 +11,6 @@
 final class ArgumentAdder
 {
     /**
-     * @param class-string $class
      * @param mixed|null $argumentDefaultValue
      */
     public function __construct(

diff --git a/rules/Arguments/ValueObject/RemoveMethodCallParam.php b/rules/Arguments/ValueObject/RemoveMethodCallParam.php
@@ -8,9 +8,6 @@
 
 final class RemoveMethodCallParam
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $methodName,

diff --git a/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php b/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php
@@ -16,7 +16,6 @@ final class ReplaceArgumentDefaultValue implements ReplaceArgumentDefaultValueIn
     public const ANY_VALUE_BEFORE = '*ANY_VALUE_BEFORE*';
 
     /**
-     * @param class-string $class
      * @param int<0, max> $position
      */
     public function __construct(

diff --git a/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php b/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php
@@ -8,9 +8,6 @@
 
 final class BinaryToVersionCompareCondition implements ConditionInterface
 {
-    /**
-     * @param class-string $binaryClass
-     */
     public function __construct(
         private readonly VersionCompareCondition $versionCompareCondition,
         private readonly string $binaryClass,

diff --git a/rules/Php80/ValueObject/ClassNameAndTagValueNode.php b/rules/Php80/ValueObject/ClassNameAndTagValueNode.php
@@ -10,9 +10,6 @@
 
 final class ClassNameAndTagValueNode
 {
-    /**
-     * @param class-string $enumClass
-     */
     public function __construct(
         private readonly string $enumClass,
         private readonly ParamTagValueNode|ReturnTagValueNode|VarTagValueNode $tagValueNode

diff --git a/rules/Privatization/ValueObject/ReplaceStringWithClassConstant.php b/rules/Privatization/ValueObject/ReplaceStringWithClassConstant.php
@@ -10,7 +10,6 @@
 final class ReplaceStringWithClassConstant
 {
     /**
-     * @param class-string $class
      * @param class-string $classWithConstants
      */
     public function __construct(

diff --git a/rules/Removing/ValueObject/ArgumentRemover.php b/rules/Removing/ValueObject/ArgumentRemover.php
@@ -9,9 +9,6 @@
 
 final class ArgumentRemover
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $method,

diff --git a/rules/Renaming/ValueObject/MethodCallRename.php b/rules/Renaming/ValueObject/MethodCallRename.php
@@ -10,9 +10,6 @@
 
 final class MethodCallRename implements MethodCallRenameInterface
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $oldMethod,

diff --git a/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php b/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php
@@ -10,9 +10,6 @@
 
 final class MethodCallRenameWithArrayKey implements MethodCallRenameInterface
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $oldMethod,

diff --git a/rules/Renaming/ValueObject/RenameClassAndConstFetch.php b/rules/Renaming/ValueObject/RenameClassAndConstFetch.php
@@ -10,10 +10,6 @@
 
 final class RenameClassAndConstFetch implements RenameClassConstFetchInterface
 {
-    /**
-     * @param class-string $oldClass
-     * @param class-string $newClass
-     */
     public function __construct(
         private readonly string $oldClass,
         private readonly string $oldConstant,

diff --git a/rules/Renaming/ValueObject/RenameClassConstFetch.php b/rules/Renaming/ValueObject/RenameClassConstFetch.php
@@ -10,9 +10,6 @@
 
 final class RenameClassConstFetch implements RenameClassConstFetchInterface
 {
-    /**
-     * @param class-string $oldClass
-     */
     public function __construct(
         private readonly string $oldClass,
         private readonly string $oldConstant,

diff --git a/rules/Renaming/ValueObject/RenameStaticMethod.php b/rules/Renaming/ValueObject/RenameStaticMethod.php
@@ -9,10 +9,6 @@
 
 final class RenameStaticMethod
 {
-    /**
-     * @param class-string $oldClass
-     * @param class-string $newClass
-     */
     public function __construct(
         private readonly string $oldClass,
         private readonly string $oldMethod,

diff --git a/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php b/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php
@@ -9,9 +9,6 @@
 
 final class ArgumentFuncCallToMethodCall implements ArgumentFuncCallToMethodCallInterface
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $function,
         private readonly string $class,

diff --git a/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php b/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php
@@ -11,7 +11,7 @@ final class ArrayFuncCallToMethodCall implements ArgumentFuncCallToMethodCallInt
 {
     /**
      * @param non-empty-string $function
-     * @param class-string $class
+     * @param non-empty-string $class
      * @param non-empty-string $arrayMethod
      * @param non-empty-string $nonArrayMethod
      */

diff --git a/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php b/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php
@@ -7,8 +7,6 @@
 final class AttributeKeyToClassConstFetch
 {
     /**
-     * @param class-string $attributeClass
-     * @param class-string $constantClass
      * @param array<string, string> $valuesToConstantsMap
      */
     public function __construct(

diff --git a/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php b/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php
@@ -9,10 +9,6 @@
 
 final class DimFetchAssignToMethodCall
 {
-    /**
-     * @param class-string $listClass
-     * @param class-string $itemClass
-     */
     public function __construct(
         private readonly string $listClass,
         private readonly string $itemClass,

diff --git a/rules/Transform/ValueObject/MethodCallToStaticCall.php b/rules/Transform/ValueObject/MethodCallToStaticCall.php
@@ -9,10 +9,6 @@
 
 final class MethodCallToStaticCall
 {
-    /**
-     * @param class-string $oldClass
-     * @param class-string $newClass
-     */
     public function __construct(
         private readonly string $oldClass,
         private readonly string $oldMethod,

diff --git a/rules/Transform/ValueObject/NewToStaticCall.php b/rules/Transform/ValueObject/NewToStaticCall.php
@@ -9,9 +9,6 @@
 
 final class NewToStaticCall
 {
-    /**
-     * @param class-string $staticCallClass
-     */
     public function __construct(
         private readonly string $type,
         private readonly string $staticCallClass,

diff --git a/rules/Transform/ValueObject/PropertyAssignToMethodCall.php b/rules/Transform/ValueObject/PropertyAssignToMethodCall.php
@@ -9,9 +9,6 @@
 
 final class PropertyAssignToMethodCall
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $oldPropertyName,

diff --git a/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php b/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php
@@ -9,9 +9,6 @@
 
 final class ReplaceParentCallByPropertyCall
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $method,

diff --git a/rules/Transform/ValueObject/StaticCallToFuncCall.php b/rules/Transform/ValueObject/StaticCallToFuncCall.php
@@ -9,9 +9,6 @@
 
 final class StaticCallToFuncCall
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $method,

diff --git a/rules/Transform/ValueObject/StaticCallToMethodCall.php b/rules/Transform/ValueObject/StaticCallToMethodCall.php
@@ -12,9 +12,6 @@
 
 final class StaticCallToMethodCall
 {
-    /**
-     * @param class-string $staticClass
-     */
     public function __construct(
         private readonly string $staticClass,
         private readonly string $staticMethod,

diff --git a/rules/Transform/ValueObject/StaticCallToNew.php b/rules/Transform/ValueObject/StaticCallToNew.php
@@ -8,9 +8,6 @@
 
 final class StaticCallToNew
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $method

diff --git a/rules/Transform/ValueObject/StringToClassConstant.php b/rules/Transform/ValueObject/StringToClassConstant.php
@@ -8,9 +8,6 @@
 
 final class StringToClassConstant
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $string,
         private readonly string $class,

diff --git a/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php b/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php
@@ -9,9 +9,6 @@
 
 final class AddPropertyTypeDeclaration
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $propertyName,

diff --git a/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php b/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php
@@ -10,9 +10,6 @@
 
 final class AddReturnTypeDeclaration
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $method,

diff --git a/rules/Visibility/ValueObject/ChangeConstantVisibility.php b/rules/Visibility/ValueObject/ChangeConstantVisibility.php
@@ -9,9 +9,6 @@
 
 final class ChangeConstantVisibility
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $constant,

diff --git a/rules/Visibility/ValueObject/ChangeMethodVisibility.php b/rules/Visibility/ValueObject/ChangeMethodVisibility.php
@@ -8,9 +8,6 @@
 
 final class ChangeMethodVisibility
 {
-    /**
-     * @param class-string $class
-     */
     public function __construct(
         private readonly string $class,
         private readonly string $method,