Fix/do not inline constructor default when readonly (#2720)

* fix: inline constructor default readonly * test: inline constructor default readonly
rectorphp · Jul 28, 2022 · ec291c4 · ec291c4
1 parent d94353a
commit ec291c4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/...or/Class_/InlineConstructorDefaultToPropertyRector/Fixture/do_not_change_readonly.php.inc b/...or/Class_/InlineConstructorDefaultToPropertyRector/Fixture/do_not_change_readonly.php.inc
@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector\Fixture;
+
+final class DoNotChangeReadonly
+{
+    private readonly string $name;
+
+    public function __construct()
+    {
+        $this->name = 'John';
+    }
+}
diff --git a/rules/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector.php b/rules/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector.php
@@ -83,6 +83,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($property->isReadonly()) {
+                continue;
+            }
+
             $propertyProperty = $property->props[0];
             $propertyProperty->default = $defaultPropertyExprAssign->getDefaultExpr();