[DeadCode] Skip global and static variable on RemoveJustVariableAssig…

…nRector (#2641)

* [DeadCode] Skip global var on RemoveJustVariableAssignRector

* update

* skip static as well

* skip static as well

* skip static as well

* s

* Fixed 🎉

* eol

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector/Fixture/skip_global_var.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector\Fixture;
+
+$result = 1;
+
+function run()
+{
+    global $result;
+    $result = 100;
+
+    $temporaryValue = $result;
+}

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector/Fixture/skip_static_var.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector\Fixture;
+
+class SkipStaticVar
+{
+    private $property;
+
+    function init($value)
+    {
+        static $result = null;
+
+        if (! isset($result)) {
+            $result = $value;
+            $this->property = $result;
+        }
+    }
+}

rules/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector.php

@@ -159,6 +159,10 @@ private function areTwoVariablesCrossAssign(Assign $currentAssign, Assign $nextA
             return false;
         }
 
+        if ($this->variableAnalyzer->isStaticOrGlobal($currentAssign->var)) {
+            return false;
+        }
+
         return ! $this->exprUsedInNextNodeAnalyzer->isUsed($nextAssign->expr);
     }