skip next array dim fetch

rectorphp · Jul 3, 2022 · 7c5108c · 7c5108c
1 parent 0637894
commit 7c5108c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/...r/StmtsAwareInterface/RemoveJustVariableAssignRector/Fixture/skip_array_dim_fetch.php.inc b/...r/StmtsAwareInterface/RemoveJustVariableAssignRector/Fixture/skip_array_dim_fetch.php.inc
@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector\Fixture;
+
+final class SkipArrayDimFetch
+{
+    private int $temporaryValue;
+
+    public function run()
+    {
+        $result = 100;
+
+        $this->temporaryValue[] = $result;
+    }
+}
diff --git a/rules/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector.php b/rules/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector.php
@@ -5,6 +5,7 @@
 namespace Rector\DeadCode\Rector\StmtsAwareInterface;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\Ternary;
 use PhpParser\Node\Expr\Variable;
@@ -103,6 +104,11 @@ public function refactor(Node $node): ?Node
 
             $nextAssign = $nextStmt->expr;
 
+            // too complex
+            if ($nextAssign->var instanceof ArrayDimFetch) {
+                continue;
+            }
+
             if (! $this->areTwoVariablesCrossAssign($currentAssign, $nextAssign)) {
                 continue;
             }