add multi args acceptor (#2605)

rules-tests/CodeQuality/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/with_join_args.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ReturnTypeFromStrictScalarReturnExprRector\Fixture;
+
+final class WithJoinArgs
+{
+    public function run($value)
+    {
+        if ($value) {
+            return join('', ['a', 'b']);
+        }
+
+        return 'string';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ReturnTypeFromStrictScalarReturnExprRector\Fixture;
+
+final class WithJoinArgs
+{
+    public function run($value): string
+    {
+        if ($value) {
+            return join('', ['a', 'b']);
+        }
+
+        return 'string';
+    }
+}
+
+?>

rules/TypeDeclaration/TypeAnalyzer/AlwaysStrictScalarExprAnalyzer.php

@@ -14,6 +14,7 @@
 use PhpParser\Node\Scalar\MagicConst;
 use PhpParser\Node\Scalar\MagicConst\Line;
 use PhpParser\Node\Scalar\String_;
+use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\Native\NativeFunctionReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Reflection\ReflectionProvider;
@@ -23,6 +24,7 @@
 use PHPStan\Type\NullType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 
 final class AlwaysStrictScalarExprAnalyzer
 {
@@ -97,7 +99,22 @@ private function resolveFuncCallType(FuncCall $funcCall): ?Type
             return null;
         }
 
-        $parametersAcceptor = ParametersAcceptorSelector::selectSingle($functionReflection->getVariants());
+        $variants = $functionReflection->getVariants();
+        if (count($variants) > 1) {
+            $scope = $funcCall->getAttribute(AttributeKey::SCOPE);
+            if ($scope instanceof Scope) {
+                $parametersAcceptor = ParametersAcceptorSelector::selectFromArgs(
+                    $scope,
+                    $funcCall->getArgs(),
+                    $variants
+                );
+            } else {
+                return null;
+            }
+        } else {
+            $parametersAcceptor = ParametersAcceptorSelector::selectSingle($variants);
+        }
+
         return $parametersAcceptor->getReturnType();
     }
 }