Reimplement WithConsecutiveRector (#311) #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you run: to make CI green? Thank you. |
|
Thanks for the proposal. It's quite difficult to review the match to switch change. We actully promote newer PHP and PHPUnit 10 is already on PHP 8+, so match is a valid option. Could you keep the Thanks |
|
@TomasVotruba When can I expect a review? |
samsonasik
reviewed
Apr 18, 2024
tests/Rector/StmtsAwareInterface/WithConsecutiveRector/Fixture/exclude_will.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Apr 18, 2024
tests/Rector/StmtsAwareInterface/WithConsecutiveRector/Fixture/exclude_will_return_map.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Apr 18, 2024
...ector/StmtsAwareInterface/WithConsecutiveRector/Fixture/exclude_will_return_callback.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
approved these changes
Apr 22, 2024
|
Thanks for reviews @samsonasik 👍 Let's give this a go 👏 |
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#311 I tried to reimplement WithConsecutiveRector because the previous implementation is incorrect.
I think i need to refactor the code.
It's my first time using phpparser and contributing on github. I am open to suggestions for improvements. :)