-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation to attributes rector isn't complete #116
Comments
I've reported the same issue here rectorphp/rector#7163 (comment) |
Hi @b1rdex , thanks for the report and git diffs. It really helped me to understand what needed to changed and how 🙂 At start I got really confused by Doctrine docs, that suprisingly has no manual how to upgrade even basic annotations. Instead of making the basic rule do too many things like before, we introduced a new rule That way we have 2 clean rules with separated jobs 👍 This is already deployed in the latest Rector |
Hi! I found some problems using rector to transform annotations to attributes:
@Index
must be moved out of@Table
(Table attribute was deleted as it's not necessary anymore)
same for unique constraints
(Table attribute was deleted as it's not necessary anymore)
@JoinTable
should be splitI had to do these modifications manually after the initial rector run – these were not easy to find, partly because of silent BC by Doctrine.
I found some information about these in doctrine/orm#9334 (comment) and https://www.doctrine-project.org/projects/doctrine-orm/en/2.11/reference/attributes-reference.html
The text was updated successfully, but these errors were encountered: