Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes 1.30 et al #519

Merged
merged 1 commit into from Apr 25, 2024
Merged

Kubernetes 1.30 et al #519

merged 1 commit into from Apr 25, 2024

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Apr 24, 2024

Upstream breaking changes are reflected here.

golang -> 1.22.0
controller-runtime -> 0.18.0
dies -> 0.12.0

Upstream breaking changes are reflected here.

golang -> 1.22.0
controller-runtime -> 0.18.0
dies -> 0.12.0

Signed-off-by: Scott Andrews <scott@andrews.me>
@scothis scothis requested a review from mamachanko April 24, 2024 16:55
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.59%. Comparing base (784d8b5) to head (62bc6ee).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   61.13%   59.59%   -1.54%     
==========================================
  Files          28       31       +3     
  Lines        2583     2772     +189     
==========================================
+ Hits         1579     1652      +73     
- Misses        917     1028     +111     
- Partials       87       92       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scothis scothis marked this pull request as ready for review April 24, 2024 17:48
Copy link
Contributor

@mamachanko mamachanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@scothis scothis merged commit db48997 into reconcilerio:main Apr 25, 2024
3 of 4 checks passed
@scothis scothis deleted the k8s-1.30 branch April 25, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants