Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for params, data, and json as positional arguments to CachedSession.request() #525

Merged
merged 2 commits into from Feb 13, 2022
Merged

Fix support for params, data, and json as positional arguments to CachedSession.request() #525

merged 2 commits into from Feb 13, 2022

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Feb 13, 2022

Fixes #524

@codecov-commenter
Copy link

Codecov Report

Merging #525 (db7444d) into master (aafc42f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head db7444d differs from pull request most recent head fea0eff. Consider uploading reports for the commit fea0eff to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #525   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          18       18           
  Lines        1295     1295           
  Branches      188      188           
=======================================
  Hits         1277     1277           
  Misses          9        9           
  Partials        9        9           
Impacted Files Coverage Δ
requests_cache/session.py 99.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aafc42f...fea0eff. Read the comment docs.

@JWCook JWCook changed the title Fix support for params data, and json as positional arguments to CachedSession.request() Fix support for params, data, and json as positional arguments to CachedSession.request() Feb 13, 2022
@JWCook JWCook merged commit ebb5f69 into requests-cache:master Feb 13, 2022
@JWCook JWCook deleted the fix-params-positional-arg branch February 13, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query parameters are stripped since 0.9.0
2 participants