Bugfix: Expect 201 upon a successful ArticleAPI.create call #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
201 is the standard HTTP status response code when successfully creating a resource. Backend frameworks like NestJS return 201 when responding to POST requests (https://docs.nestjs.com/controllers#status-code).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
201 is the standard HTTP status response code when successfully creating a resource. Backend frameworks like NestJS return 201 when responding to POST requests (https://docs.nestjs.com/controllers#status-code).
Bug reproduction
I came across this issue with vanilla installations of this repo (from commit be9ef56) as frontend, and of the NestJS+MikroORM repo (commit 827cee98b3b6078d26860b5251b3587e29de6484) as backend.
Then, simply create an Article using the UI to land in the if clause in the modified code, which triggers
setErrorswithout an error having occurred.Fix
Backend reasonably fires 201 upon success, so expect a 201.