Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add JSDoc to fix linter error #2964

Merged
merged 1 commit into from Oct 12, 2022

Conversation

nikolasrieble
Copy link
Contributor

@nikolasrieble nikolasrieble commented Sep 9, 2022

This PR by @saghan broke the CI pipeline, which now fails due to a linter error.

Run tsc --noEmit

> recharts@2.1.13 lint /home/runner/work/recharts/recharts
> eslint './src/**/*.?(ts|tsx)'


/home/runner/work/recharts/recharts/src/cartesian/CartesianAxis.tsx
Error:   450:3  error  Missing JSDoc for parameter 'fontSize'       valid-jsdoc
Error:   450:3  error  Missing JSDoc for parameter 'letterSpacing'  valid-jsdoc

Adding JSDoc for two arguments is sufficient to fix this.

@nikolasrieble nikolasrieble changed the title Fix linter warning Fix: Add JSDoc to fix linter error Sep 9, 2022
@saghan
Copy link
Contributor

saghan commented Sep 9, 2022

Thank you, the fix is also there in this #2949

@nikolasrieble
Copy link
Contributor Author

I will leave this open in case the other PR does not get merged. Once the other one is merged, this can be closed either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants