add eslint exception to fix failing build #2925
Closed
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be better to change this to an interactive element and remove all styles? |
|
I looked into what interactive element might be suitable as a Tooltip but didn't find any. The only interaction that is expected from users is pressing Escape key. I am open to any suggestions that you might have. |
|
agreed, I'll incorporate it into the other branch |
|
Closing this because the changes are in #2924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an eslint exception because we need to listen to 'Escape' key to dismiss Tooltip although it is non-interactive element. (The build failure is due to unrelated changes that are merged)