Support keyboard navigation in pie chart #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be unblocked by #2924 |
|
I have pushed an empty commit to re-run the tests. |
|
Tests failing for JS doc issues, @saghan can you take a look? |
Done |
semoal
approved these changes
Oct 3, 2022
ckifer
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We are planning to use ReCharts in Microsoft Azure. We want to improve accessibility of the charts and contribute to this repository so that everyone using ReCharts can have a good experience.
This change is trying to enable users to navigate through pie chart using keyboard. Web Content Accessibility Guidelines suggests developers to add this ability to improve accessibility. If this change is accepted, Recharts users can navigate through pie chart using keyboard.
Since we use Enzyme+Cheerio in Recharts, which does not render test components in browser, I had to add dev-dependency on react testing library to test focus and navigation. This dependency will also help developers do a more thorough testing. Please let me know if you have any comments.