This repository has been archived by the owner on Aug 5, 2019. It is now read-only.
Provide esm output #2
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| module.exports = { | ||
| presets: [ | ||
| ["@babel/env", { | ||
| modules: process.env.NODE_ENV.includes('cjs') || | ||
| process.env.NODE_ENV === 'test' | ||
| ? 'commonjs' | ||
| : false | ||
| }], | ||
| "@babel/react" | ||
| ], | ||
| plugins: [] | ||
| } | ||
|
|
||
| if (process.env.NODE_ENV.includes('emotion')) { | ||
| module.exports.plugins.push([ | ||
| 'transform-rename-import', | ||
| { | ||
| original: 'styled-components', | ||
| replacement: 'react-emotion' | ||
| } | ||
| ]) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export * from './dist/emotion'; | ||
| export { default } from './dist/emotion'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could still be handled with the
envfield right? Sorry haven't had time to dig into some of the Babel 7 changes yetThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
envfield works only with json config. I use js here to achieve some logic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I haven't seen anything about the
envfield being deprecated in Babel 7 – if you happen to have a link to the docs that'd be helpfulThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not deprecated (well, it was for a while).
envfield just not used by js config. Consider json version withenvfield is a wrapper around it. Don't know where this mentioned in docs to be honest.