Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #625 fix security vulnerabilities #639

Merged
merged 3 commits into from Mar 19, 2020
Merged

chore: #625 fix security vulnerabilities #639

merged 3 commits into from Mar 19, 2020

Conversation

vuhuucuong
Copy link
Contributor

fixes: #625

@vuhuucuong
Copy link
Contributor Author

vuhuucuong commented Mar 17, 2020 •
edited

Look like typescript-eslint is broken after update and cause the pipeline to fail, they're currently fixing it: typescript-eslint/typescript-eslint#1746
Please wait until it's fixed, before we merge

@vuhuucuong vuhuucuong added the do not merge Branch should not be merged into main workflow in current state label Mar 17, 2020
@willmcvay
Copy link
Contributor

Understood, will leave for now

@vuhuucuong
Copy link
Contributor Author

vuhuucuong commented Mar 19, 2020 •
edited

Downgraded to 2.23.0 as suggested in here typescript-eslint/typescript-eslint#1746 (comment)
Since we're using typescript 3.7
Everything is okay now

@vuhuucuong vuhuucuong removed the do not merge Branch should not be merged into main workflow in current state label Mar 19, 2020
duong-se
duong-se approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit af0dabe into master Mar 19, 2020
@duong-se duong-se deleted the chore/625-fix-security-vulnerabilities branch March 19, 2020 08:29
phmngocnghia pushed a commit that referenced this pull request Apr 29, 2020
fix: #639 - selectbox styles
c9699e1
duong-se pushed a commit that referenced this pull request Apr 29, 2020
fix: #639 - selectbox styles (#1108)
9277794
willmcvay pushed a commit that referenced this pull request Apr 29, 2020
fix: #639 - selectbox styles (#1108)
78e0c00
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
chore: #625 fix security vulnerabilities (#639)
582d861 
* chore: #625 fix security vulnerabilities

* fix: vulnerabilities fix

* chore: #625 downgrade typescript-eslint to 2.23.0
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong-se duong-se duong-se approved these changes

@phmngocnghia phmngocnghia phmngocnghia approved these changes

@dannd4 dannd4 Awaiting requested review from dannd4

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@vuhuucuong vuhuucuong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address security vulnerabilities in Foundations
4 participants
@vuhuucuong @willmcvay @duong-se @phmngocnghia