Skip to content

Commit

Permalink
Feat/755 developers can specify who can see their apps (#827)
Browse files Browse the repository at this point in the history
* feat: #755: Add private apps section to submit app form

* feat: #755: Devs can specify who can see their apps

* feat: #755: Update snapshot testing

* feat: #755: Reword the validation - Fix submit app issues with whitespaces
  • Loading branch information
Vu Nguyen committed Apr 6, 2020
1 parent 6e72e88 commit d1cd564
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ export const handleSubmitApp = ({
}

if (appModel.isPrivateApp === 'yes') {
appToSubmit.limitToClientIds = limitToClientIds ? limitToClientIds.split(',') : []
appToSubmit.limitToClientIds = limitToClientIds ? limitToClientIds.replace(/ /g, '').split(',') : []
}

if (!appId) {
Expand Down
2 changes: 1 addition & 1 deletion packages/marketplace/src/utils/form/submit-app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const validate = (values: CustomCreateAppModel) => {
}

if (values.limitToClientIds && !isValidLimitToClientIds(values.limitToClientIds)) {
errors.limitToClientIds = 'Invalid Customer ID(s). Each Customer ID must has exactly 3 characters'
errors.limitToClientIds = 'Invalid Customer ID(s). Each Customer ID should consist of 3 characters.'
}

if (values.homePage && !whiteListLocalhostAndIsValidUrl(values.homePage) && !isValidHttpUrl(values.homePage)) {
Expand Down

0 comments on commit d1cd564

Please sign in to comment.