Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable Cocoapods Catalyst CI tests #7059

Merged
merged 1 commit into from Jan 25, 2021

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented Jan 20, 2021

These will continue failing until CocoaPods/CocoaPods#10224 is fixed and it isn't very useful to have it run on every PR until then.

These will continue failing until
CocoaPods/CocoaPods#10224 is fixed and it isn't very
useful to have it run on every PR until then.
@tgoyne tgoyne self-assigned this Jan 20, 2021
Copy link
Contributor

@jsflax jsflax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM bar one comment

@@ -46,7 +46,7 @@ def minimum_version(major)
'cocoapods-ios' => oldest_and_latest,
'cocoapods-ios-dynamic' => oldest_and_latest,
'cocoapods-watchos' => oldest_and_latest,
'cocoapods-catalyst' => oldest_and_latest,
# 'cocoapods-catalyst' => oldest_and_latest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add a FIXME here as a reminder

@tgoyne tgoyne merged commit 66b809a into master Jan 25, 2021
@tgoyne tgoyne deleted the tg/disable-catalyst-tests branch January 25, 2021 23:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants