Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - replace deprecated set-output #986

Merged
merged 17 commits into from
Nov 9, 2022
Merged

CI - replace deprecated set-output #986

merged 17 commits into from
Nov 9, 2022

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Oct 24, 2022 •
edited

Migrate CI actions to their new commits sha because of deprecated set-output. Required:

@cla-bot cla-bot bot added the cla: yes label Oct 24, 2022
@desistefanova desistefanova added the no-changelog Used to skip the changelog check label Oct 24, 2022
@coveralls
Copy link

coveralls commented Oct 24, 2022 •
edited

Pull Request Test Coverage Report for Build 3419943101

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.842%
Totals Coverage Status
Change from base Build 3405163886: 0.0%
Covered Lines: 2747
Relevant Lines: 3092
💛 - Coveralls

@desistefanova desistefanova changed the title CI - replace deprecated set-output with $GITHUB_OUTPUT CI - replace deprecated set-output Oct 24, 2022
@desistefanova desistefanova marked this pull request as ready for review November 7, 2022 13:37
blagoev
blagoev approved these changes Nov 7, 2022
View reviewed changes
.github/workflows/build-native.yml Show resolved Hide resolved
@desistefanova
Copy link
Contributor Author

We decided to use commits sha in order to keep our CI stable.

nielsenko
nielsenko approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@desistefanova desistefanova merged commit 6033910 into master Nov 9, 2022
@desistefanova desistefanova deleted the ci_github_outputs branch November 9, 2022 16:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko nielsenko approved these changes

Assignees

@desistefanova desistefanova

Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@desistefanova @coveralls @nirinchev @blagoev @nielsenko