Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI actions - fixed Node16 #965

Merged
merged 6 commits into from Oct 17, 2022
Merged

CI actions - fixed Node16 #965

merged 6 commits into from Oct 17, 2022

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Oct 13, 2022 •
edited

@cla-bot cla-bot bot added the cla: yes label Oct 13, 2022
@desistefanova desistefanova added the no-changelog Used to skip the changelog check label Oct 13, 2022
@desistefanova desistefanova mentioned this pull request Oct 13, 2022
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3244359818

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.2%) to 92.558%
Totals Coverage Status
Change from base Build 3229591493: 4.2%
Covered Lines: 398
Relevant Lines: 430
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 13, 2022 •
edited

Pull Request Test Coverage Report for Build 3267281799

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 161 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+4.2%) to 92.558%
Files with Coverage Reduction New Missed Lines %
lib/src/realm_class.dart 14 93.24%
lib/src/native/realm_core.dart 147 88.27%
Totals Coverage Status
Change from base Build 3229591493: 4.2%
Covered Lines: 398
Relevant Lines: 430
💛 - Coveralls

@desistefanova desistefanova marked this pull request as ready for review October 17, 2022 13:40
blagoev
blagoev approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good. Could we add a task to migrate back to the v2 or the v3 versions of all these when they are merged. Since we will be missing important updates to these tags if any in the future. I guess we can check in 2-3 months if these got updated and migrate back.

@desistefanova
Copy link
Contributor Author

Added Issue #971

@desistefanova desistefanova merged commit 9704b70 into master Oct 17, 2022
@desistefanova desistefanova deleted the ds/update_ci_actions branch October 17, 2022 17:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko Awaiting requested review from nielsenko

Assignees

@desistefanova desistefanova

Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI action to use Node16
4 participants
@desistefanova @coveralls @nirinchev @blagoev