Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Slack message if the CI fails on main branch #1232

Merged
merged 46 commits into from
Jun 1, 2023
Merged

Send Slack message if the CI fails on main branch #1232

merged 46 commits into from
Jun 1, 2023

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Mar 28, 2023 •
edited

Related to #940 and #971
Slack a message to internal channel in case of CI failure in main branch.
image

@cla-bot cla-bot bot added the cla: yes label Mar 28, 2023
@desistefanova desistefanova changed the title Send Slack message when main CI fails Send Slack message if CI fails on main branch Mar 28, 2023
@desistefanova desistefanova changed the title Send Slack message if CI fails on main branch Send Slack message if the CI fails on main branch Mar 28, 2023
@desistefanova desistefanova added the no-changelog Used to skip the changelog check label Mar 28, 2023
@coveralls
Copy link

coveralls commented May 25, 2023 •
edited

Pull Request Test Coverage Report for Build 5129977234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 89.256%
Files with Coverage Reduction New Missed Lines %
lib/src/subscription.dart 1 90.48%
Totals Coverage Status
Change from base Build 5078382290: -0.03%
Covered Lines: 3132
Relevant Lines: 3509
💛 - Coveralls

@desistefanova desistefanova marked this pull request as ready for review May 29, 2023 11:28
@desistefanova desistefanova marked this pull request as draft May 29, 2023 11:54
@desistefanova desistefanova marked this pull request as ready for review May 29, 2023 12:24
blagoev
blagoev reviewed May 29, 2023
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some questions mostly.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
nielsenko
nielsenko requested changes May 31, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@desistefanova desistefanova merged commit e944ca3 into main Jun 1, 2023
48 of 49 checks passed
@desistefanova desistefanova deleted the ds/slack_when_main_ci_fails branch June 1, 2023 08:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko nielsenko approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees

@desistefanova desistefanova

Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@desistefanova @coveralls @blagoev @nielsenko