Fix path resolution for axe.min.js #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reallymello
requested changes
Jul 5, 2023
nightwatch/commands/axeInject.js
Outdated
| @@ -1,26 +1,8 @@ | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
There was a problem hiding this comment.
Thanks for your contribution. Would you be able to remove the unused path variable on line 2 and resubmit @justafish ?
There was a problem hiding this comment.
@reallymello done! 👍
|
Thanks 2.2.2 should have your changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current path resolution doesn't work for package managers that don't use that path scheme (e.g. Yarn > 2). This PR replaces the hard coded path with the correct function for resolving module files.
You can reproduce this error by installing the latest version of Nightwatch with the latest version of Yarn.