[C#] Avoid ToString() affect the message internal state #993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR intends to fix Issue 992.
The current generate ToString() implementation calls to
this.BuildString()
which changethis
state.To avoid the affect ton
this
, I changed the generatedToString()
to create a new instance of the message, wrap it and then use it withBuildString()
. This waythis
is not affected.The assumption is that
ToString()
is only called for logging and debugging purposes, so the extra object created doesn't affect performance.Ami