2.0 milestone: drop supported versions #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
force-pushed
the
humitos/drop-supported-versions
branch
from
6e4950d
to
e32540c
Compare
agjohnson
reviewed
Aug 11, 2023
There was a problem hiding this comment.
This doesn't quite match what Sphinx 5 supports, so I don't think we should make all of these changes. I would be in favor of more aggressive tuning on what we visually test against -- mostly Python versions really, but perhaps docutils versions too.
Once our support matrix drops Sphinx 5 these will get tighter, but I think 5 usage is still high enough to warrant support. We're just at an unfortunate stage where our dependency graph and Sphinx's dependency graph is very wide still.
The new policy is: - Python >=3.6 - Sphinx >= 5 - HTML4 and HTML5 writer - docutils >= 0.14, < 0.19
By the beginning of 2024 we should support newer Sphinx versions and HTML5 only.
humitos
force-pushed
the
humitos/drop-supported-versions
branch
from
b625bfb
to
136b275
Compare
|
@agjohnson I updated this PR with the changes suggested. Let me know if you OK with this. I'd be happy to move forward and get closer to a 2.0 release 🚀 |
agjohnson
reviewed
Aug 17, 2023
- drop support for HTML4 on 2.0 - keep `-qa` TOX environment to be able to compare feature branches - emit `logger.errors` on Python 2 and html_writer4=True - require Sphinx >= 5.0 - remove logic for old Sphinx versions
|
@agjohnson I updated this PR with some changes from your feedback. |
agjohnson
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new policy is:
HTML4 andHTML5 writer