Replaces the Jinja2 dependecy with a meta package 馃く #1359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaoming
force-pushed
the
sphinx-rtd-theme-meta-jinja2-dependency
branch
from
1068f41
to
02d5962
Compare
|
I noted on #1358 another way to resolve the issue you noted. My preference would be dropping the dependency, or keeping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for fixing #1358
Notice that the sphinx-rtd-theme-meta-jinja2-dependency actually exists.
We only need this extra dependency for Python 3, since Jinja2 dropped Python 2.7 in version 3.0.0, so this will suffice as the upper bound for all Python 2 deployments.