Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move context logic for layout.html to jinja #1356

Merged
merged 3 commits into from Oct 12, 2022
Merged

Move context logic for layout.html to jinja #1356

merged 3 commits into from Oct 12, 2022

Commits on Oct 11, 2022

  1. Revert "Update layout.html to support a sphinx version that is not th… 

    …ree-integers (readthedocs#1345)"

This reverts commit 45cf218.
    @benjaoming
    benjaoming committed Oct 11, 2022
    Copy the full SHA
    cf56f99 View commit details
    Browse the repository at this point in the history

  2. Always slice list before unpacking so number of elements is expected … 

    …range

`map` filter returns a generator that needs to run through the `list` filter before slicing
    @benjaoming
    benjaoming committed Oct 11, 2022
    Copy the full SHA
    a93bd83 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Let's keep it a 3-tuple but always set 3rd component to -1 -- in case… 

    … a project was unpacking 3 values
    @benjaoming
    benjaoming committed Oct 12, 2022
    Copy the full SHA
    c7f5f74 View commit details
    Browse the repository at this point in the history