Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build assets in Docker container + use same container setup in CI #1312

Closed
wants to merge 21 commits into from

Commits on Aug 16, 2022

  1. Configuration menu
    Copy the full SHA
    e58f867 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Configuration menu
    Copy the full SHA
    651007e View commit details
    Browse the repository at this point in the history
  2. Fix invalid version "1.0.1alpha1" (npm breaks) - bump some dependenci…

    …es in preparation for python3
    benjaoming committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    aaf494b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    48dab6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9025a96 View commit details
    Browse the repository at this point in the history
  5. Fix syntax issue

      :not(kbd) > kbd,
     ^
          Property "not" must be followed by a ':'
          in /project/src/sass/_theme_rst.sass (line 518, column 3)
        at /project/node_modules/webpack/lib/NormalModule.js:316:20
        at /project/node_modules/loader-runner/lib/LoaderRunner.js:367:11
        at /project/node_modules/loader-runner/lib/LoaderRunner.js:233:18
        at context.callback (/project/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
        at Object.callback (/project/node_modules/sass-loader/dist/index.js:89:7)
        at Object.done [as callback] (/project/node_modules/neo-async/async.js:8069:18)
        at options.error (/project/node_modules/node-sass/lib/index.js:294:32)
     @ multi ./src/theme.js ./src/sass/theme.sass theme[1]
    Child mini-css-extract-plugin node_modules/css-loader/dist/cjs.js!node_modules/sass-loader/dist/cjs.js??ref--5-2!src/sass/badge_only.sass:
        Entrypoint mini-css-extract-plugin = *
        [0] ./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/badge_only.sass 4.69 KiB {0} [built]
            + 7 hidden modules
    Child mini-css-extract-plugin node_modules/css-loader/dist/cjs.js!node_modules/sass-loader/dist/cjs.js??ref--5-2!src/sass/theme.sass:
        Entrypoint mini-css-extract-plugin = *
        [0] ./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass 227 bytes {0} [built] [failed] [1 error]
    
        ERROR in ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass)
        Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
    
          :not(kbd) > kbd,
         ^
              Property "not" must be followed by a ':'
              in /project/src/sass/_theme_rst.sass (line 518, column 3)
    benjaoming committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5d8fbba View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b654b40 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ea440e8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4577c89 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6269d47 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    43c1ab3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    deb984f View commit details
    Browse the repository at this point in the history
  12. Try "This step helps you avoid the Docker-in-Docker problem. In fact,…

    … we’re setting up an environment that is isolated from the CI (or primary) container, then using the remote host’s Docker Engine."
    benjaoming committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    7545937 View commit details
    Browse the repository at this point in the history
  13. No make in docker-ce image

    benjaoming committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    9476b62 View commit details
    Browse the repository at this point in the history
  14. Can we bind mount?

    benjaoming committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    a6c25df View commit details
    Browse the repository at this point in the history
  15. Fix CircleCI config

    Build with Node 14 installed through orbs.
    
    Fixes readthedocs#1275
    agjohnson committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    34e29e6 View commit details
    Browse the repository at this point in the history
  16. Fix SASS syntax errors from readthedocs#967

    This introduced syntax errors that were not picked up in review, the
    `:not()` psuedo selector can't lead a selector in SASS.
    agjohnson committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    2dbaef8 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    62e9976 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    0ac878a View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    3eda02d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    9d2c22f View commit details
    Browse the repository at this point in the history