Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI tests #1281

Closed
wants to merge 9 commits into from
Closed

Fix failing CI tests #1281

wants to merge 9 commits into from

Conversation

Blendify
Copy link
Member

Issue was newer node versions are not compatible with our dev envorment.
This failed because the cimg/python:3.9-node defaulted to a newer version of node.
To fix this we can use multiple images to specify a specific node version.

I settled on node:15.14.0 as it is the last working version.

After we get tests passing we can work on supporting newer node versions.

Issue was newer node versions are not compatible with our dev envorment.
This failed because the `cimg/python:3.9-node` defaulted to a newer version of node.
To fix this we can use multiple images to specify a specific node version.

I settled on `node:15.14.0` as it is the last working version.

After we get tests passing we can work on supporting newer node versions.
@Blendify Blendify requested a review from a team as a code owner January 19, 2022 01:26
@agjohnson
Copy link
Collaborator

agjohnson commented Jan 19, 2022

Yeah, it's wise to take do this in steps. I'm not sure we need to go much higher out the Node version, given the issues we've had. But, if we didn't have Node version restrictions that would be nice. Pinning at CircleCI at least solves all of our main issues at the moment.

Looks like tests are failing still, but if you have trouble here, I did solve this on a separate repo using CircleCI workspaces. There wasn't a good image available with configurable python and node version, but attaching a workspace allowed use of two separate CircleCI images.

This might be something to try out. I was playing around with a dedicated repo for testing the theme at:
https://github.com/readthedocs/test-sphinx-theme/blob/main/.circleci/config.yml

@Blendify
Copy link
Member Author

Blendify commented Jan 31, 2022

@agjohnson I am having issues getting the installed node version to get recognized in the CI path.

Do you have any suggestions here?

Also if there is a particular node version we should be using let me know and I can update the patch for that also.

@benjaoming benjaoming added this to the 1.1 milestone Aug 12, 2022
@benjaoming
Copy link
Contributor

Hi @Blendify!

Using two different approaches, we seem to have managed to run Node 14 in an okay fashion but without NVM.

I'm going to close this, as NVM currently isn't necessary, although might be useful for another type of local development setup :)

@benjaoming benjaoming closed this Aug 19, 2022
@benjaoming benjaoming deleted the fix-ci branch August 19, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants