Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the issue of Unequal number of <div> and </div> in sphinx_rtd_theme/layout.html #1274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NaincyKumariKnoldus
Copy link

I have fixed the issue of Unequal number of

and
in sphinx_rtd_theme/layout.html. Now its both equal.

Please review and merge my PR.
Thanks!

@astrojuanlu
Copy link
Contributor

I think the CI failures are unrelated, see #1275.

@nienn
Copy link
Contributor

nienn commented Jan 12, 2022

This fixes #1273

@mitya57
Copy link
Contributor

mitya57 commented Jan 15, 2022

This change is wrong. Inside the <section>, all divs are closed properly.

Perhaps you were counting two kinds of <div class="rst-content"> as two distinct tags? They are in if/else block, so should be counted as one.

Also, this file uses two-spaces indentation. Your closing tag uses is indented by an odd amount of spaces, and does not match any opening tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants