New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow keyboard to activate permalink #1162
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -200,14 +200,14 @@ | |
// This is the #href that shows up on hover. Sphinx's is terrible so I hack it away. | ||
h1, h2, h3, h4, h5, h6, dl dt, p.caption, table > caption, .code-block-caption | ||
.headerlink | ||
visibility: hidden | ||
font-size: 14px | ||
opacity: 0 | ||
Blendify marked this conversation as resolved.
Show resolved
Hide resolved
|
||
font-size: 20px | ||
margin-left: 0.5em | ||
@extend .fa | ||
&:after | ||
content: "\f0c1" | ||
font-family: FontAwesome | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently, the rendering does not match how it did previously because the font family should still be FontAwesome. Also is there a reason behind the font size change and the adjusted margin? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After losing the FontAwesome font family, I was adjusting the size and margin to match the original size better. However, as you suggested, I put FontAwesome back to match the prior style even better. Did have to include a little left margin because the link icon was pressed right against the text otherwise when not in :after content. |
||
&:hover .headerlink:after | ||
visibility: visible | ||
&:focus | ||
opacity: 1 | ||
&:hover .headerlink | ||
opacity: 1 | ||
|
||
// override the Wyrm accessibility anti-pattern of hiding button focus | ||
.btn:focus | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix the tests from failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, did that. Also specified the unicode character with
"\u..."
. Hope that kind of string literal is portable across python versions.