Make version picker keyboard-controllable #1160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blendify
requested changes
Jun 10, 2021
Comment on lines
-4
to
+9
| <span class="rst-current-version" data-toggle="rst-current-version"> | ||
| <button class="rst-current-version" aria-expanded="false" aria-controls="docs_versions" data-toggle="rst-current-version"> | ||
| <span class="fa fa-book"> Read the Docs</span> | ||
| v: {{ current_version }} | ||
| <span class="fa fa-caret-down"></span> | ||
| </span> | ||
| <div class="rst-other-versions"> | ||
| </button> | ||
| <div class="rst-other-versions" id="docs_versions"> |
There was a problem hiding this comment.
These changes need to be repeated in https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/_templates/layout.html#L11
|
@Blendify there you go. BTW, what's the purpose of that |
jonels-msft
force-pushed
the
accessible-flyout
branch
from
be4217b
to
94f6f67
Compare
|
(rebased because it looked out of date with master) |
This is used to simulate the version picker in your local dev environment. This should solve your comment above:
|
|
@Blendify I made the update you suggested, can you review again please? |
More information about the relation of elements on the page
jonels-msft
force-pushed
the
accessible-flyout
branch
from
94f6f67
to
5044458
Compare
jonels-msft
added a commit
to jonels-msft/sphinx_rtd_theme_citus
that referenced
this pull request
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the flyout opener from
<span>to<button>to make it focusable by the keyboard. Maintains anaria-expandedproperty so that screen readers can understand the state of the flyout.Fixes #948
Fixes #962
Note that when I changed
versions.htmlI couldn't see that change reflected in my running dev environment. Instead, to test, I changed the live DOM element to a button in the browser. Perhaps there's a command I need to run to make the dev environment notice and rebuild with the change in that html file.