Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nav Buttons Size #1067

Merged
merged 3 commits into from Mar 4, 2021
Merged

Fix Nav Buttons Size #1067

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b324a9
Fix Nav Buttons Size
Blendify Mar 3, 2021
c25164c
Revert "Fix Nav Buttons Size"
Blendify Mar 3, 2021
05a7729
Do not dedpuplicate code
Blendify Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/sass/_theme_layout.sass
View file
Open in desktop
Expand Up @@ -70,8 +70,7 @@ html
margin-left: -1.2em
@extend .fa
@extend .fa-plus-square-o
font-size: .8em
line-height: 1.6em
line-height: 18px
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the change to px units needed to fix this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because of https://github.com/readthedocs/sphinx_rtd_theme/blob/Blendify/nav-btn/src/sass/_theme_layout.sass#L169, I

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we should work on using one unit system, bootstrap uses rem, so we will likely use that in the future.

color: darken($menu-link-medium, 20%)

// On state for the first level
Expand All @@ -92,8 +91,7 @@ html
@extend .fa
@extend .fa-minus-square-o
display: block
font-size: .8em
line-height: 1.6em
line-height: 18px
color: darken($menu-link-medium, 30%)

li.toctree-l1.current > a
Expand Down