Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Move Breadcrumbs to layout and clean up unused rules #1059

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Blendify
Copy link
Member

I moved breadcrumbs to the rest of the layout as it seems to belong
better here.
I also went through and removed some unused rules.

These changes can be split up into two patchs if needed.

I moved breadcrumbs to the rest of the layout as it seems to belong 
better here.
I also went through and removed some unused rules.

These changes can be split up into two patchs if needed.
Comment on lines -13 to -23
code
padding: 5px
border: none
background: none
&.literal
color: $text-color
.wy-breadcrumbs-extra
margin-bottom: 0
color: $text-light
font-size: 80%
display: inline-block
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was also removed, the rest of this file was only moved.

@benjaoming
Copy link
Contributor

This would have to be updated since we have new SASS for breadcrumbs since #1073. I did kind of like this separate file, since #1073 was one of the few PRs that didn't have a merge conflict to resolve in _theme_layout.sass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants