Don't toggle terminal nodes (#1049)

Terminal nodes that are already selected shouldn't be toggled. Fix #1044
readthedocs · Feb 11, 2021 · 3ed52c4 · 3ed52c4
1 parent 6d89d9d
commit 3ed52c4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/sphinx_rtd_theme/static/js/theme.js b/sphinx_rtd_theme/static/js/theme.js
diff --git a/src/theme.js b/src/theme.js
@@ -192,8 +192,12 @@ function ThemeNav () {
         var parent_li = elem.closest('li');
         parent_li.siblings('li.current').removeClass('current');
         parent_li.siblings().find('li.current').removeClass('current');
-        parent_li.find('> ul li.current').removeClass('current');
-        parent_li.toggleClass('current');
+        var children = parent_li.find('> ul li');
+        // Don't toggle terminal elements.
+        if (children.length) {
+            children.removeClass('current');
+            parent_li.toggleClass('current');
+        }
     }
 
     return nav;