Remove URL quoting from refs before passing to Sphinx

[gibfahn]

Sphinx allows refs with spaces etc, and in fact autogenerates them with
the command autosectionlabel.

So if you put a:

[Link 1](<some ref>)
[Link 2](<https://foo.com/bar baz>)

Then the links will be some%20ref and https://foo.com/bar%20baz.

We want to keep the URL quoting for external references, but if we're
passing it as :any: to Sphinx we need to unquote so Sphinx can find
the correct reference, the <some ref> should map to:

:ref:`some ref`

Fixes: #155

[gibfahn]

This is the only actual change.

[gibfahn]

@ericholscher sorry for the direct ping, but would you mind taking a look at this? I think it should be uncontroversial.

I've been using it (via a patch --forward in my Makefile) in a project for a while now, would be great not to have to do that any more :).

---

Full patch code in case anyone else needs to do the same:

Patch script:

# Generate patch with:
cp .venv/lib/python3.*/site-packages/recommonmark/parser.py parser.py

# Edit ./parser.py to apply the change here

# Generate patch
diff -u .venv/lib/python3.*/site-packages/recommonmark/parser.py parser.py > parser.py.patch

# Commit ./parser.py.patch, delete ./parser.py

# Apply patch as part of your Makefile/setup.py:
patch --forward \
  .venv/lib/python3.*/site-packages/recommonmark/parser.py \
  < parser.py.patch \
  || true

Generated patch:

--- .venv/lib/python3.7/site-packages/recommonmark/parser.py	2019-05-16 11:29:29.045060000 +0200
+++ parser.py	2019-05-23 16:21:31.172900496 +0200
@@ -11,9 +11,9 @@
 from warnings import warn
 
 if sys.version_info < (3, 0):
-    from urlparse import urlparse
+    from urlparse import urlparse, unquote
 else:
-    from urllib.parse import urlparse
+    from urllib.parse import urlparse, unquote
 
 __all__ = ['CommonMarkParser']
 
@@ -152,7 +152,7 @@
         url_check = urlparse(destination)
         if not url_check.scheme and not url_check.fragment:
             wrap_node = addnodes.pending_xref(
-                reftarget=destination,
+                reftarget=unquote(destination),
                 reftype='any',
                 refdomain=None,  # Added to enable cross-linking
                 refexplicit=True,

[ericholscher]

Looks good, no worries on the direct ping 👍

[ericholscher]

I will try and get a release out here soon.

[gibfahn]

Thank you!

[gibfahn]

I will try and get a release out here soon.

@ericholscher any chance of a release? If there's anything I could do to help with said release let me know.

[ericholscher]

I just shipped 0.6.0 👍