Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag to use other pdf latex binaries #5405

Closed
wants to merge 3 commits into from

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 6, 2019

This is an experiment.

I tried building https://tecs-docs.readthedocs.io/ja/latest/ with xindy and xelatex and I had some success by getting a PDF with the index full in Japanese but the content is not displayed properly.

On the other hand, building just with pdflatex just fail the build and/or generate just the cover page.

xindy is not installed in our Docker image, so I created a PR for that at readthedocs/readthedocs-docker-images#98

@humitos humitos force-pushed the humitos/pdf-binary-feature-flag branch from b0d2817 to b382d0a Compare March 6, 2019 14:34
@stsewd
Copy link
Member

stsewd commented Mar 6, 2019

but the content is not displayed properly

It doesn't lookd like a solution.

I just notice that when building docs with no-ascii characters the pdf build fails too https://readthedocs.org/projects/test-builds/builds/8659499/, is that solved using any of these builders?

@humitos
Copy link
Member Author

humitos commented Mar 6, 2019

I just notice that when building docs with no-ascii characters the pdf build fails too readthedocs.org/projects/test-builds/builds/8659499, is that solved using any of these builders?

Yes, adding the feature flag to use xelatex it builds.

captura de pantalla_2019-03-06_17-17-02

It's not perfect, though:

captura de pantalla_2019-03-06_17-16-22

but that's probably a problem with the font that does not have those characters.

@humitos humitos added the PR: work in progress Pull request is not ready for full review label Mar 7, 2019
humitos added a commit that referenced this pull request Mar 12, 2019
New versions of Sphinx use `latexmk` to build the PDF files. This
command uses a file called `latexmkrc` (or `latexmkjarc` for Japanese)
which contains all the proper commands that needs to be ran depending
on different Sphinx configurations.

`latexmk` will take care by itself on the amount of phases that need
to be ran without us worrying about it.

Currently, this is not considering LATEXMKOPTS and XINDYOPTS
environment variables configured by Sphinx.

This feature is implemented under a Feature flag so we can test it
easily without breaking other working projects.

References:

- #1556
- #4454
- #5405
- toppers/tecs-docs#7
- https://github.com/sphinx-doc/sphinx/blob/master/sphinx/texinputs/Makefile_t
- https://www.sphinx-doc.org/en/master/usage/builders/index.html#sphinx.builders.latex.LaTeXBuilder
humitos added a commit that referenced this pull request Mar 12, 2019
New versions of Sphinx use `latexmk` to build the PDF files. This
command uses a file called `latexmkrc` (or `latexmkjarc` for Japanese)
which contains all the proper commands that needs to be ran depending
on different Sphinx configurations.

`latexmk` will take care by itself on the amount of phases that need
to be ran without us worrying about it.

Currently, this is not considering LATEXMKOPTS and XINDYOPTS
environment variables configured by Sphinx.

This feature is implemented under a Feature flag so we can test it
easily without breaking other working projects.

References:

- #1556
- #4454
- #5405
- toppers/tecs-docs#7
- https://github.com/sphinx-doc/sphinx/blob/master/sphinx/texinputs/Makefile_t
- https://www.sphinx-doc.org/en/master/usage/builders/index.html#sphinx.builders.latex.LaTeXBuilder
humitos added a commit that referenced this pull request Mar 13, 2019
New versions of Sphinx use `latexmk` to build the PDF files. This
command uses a file called `latexmkrc` (or `latexmkjarc` for Japanese)
which contains all the proper commands that needs to be ran depending
on different Sphinx configurations.

`latexmk` will take care by itself on the amount of phases that need
to be ran without us worrying about it.

Currently, this is not considering LATEXMKOPTS and XINDYOPTS
environment variables configured by Sphinx.

This feature is implemented under a Feature flag so we can test it
easily without breaking other working projects.

References:

- #1556
- #4454
- #5405
- toppers/tecs-docs#7
- https://github.com/sphinx-doc/sphinx/blob/master/sphinx/texinputs/Makefile_t
- https://www.sphinx-doc.org/en/master/usage/builders/index.html#sphinx.builders.latex.LaTeXBuilder
@humitos
Copy link
Member Author

humitos commented Mar 18, 2019

Closing this in favor of #5437

@humitos humitos closed this Mar 18, 2019
@stsewd stsewd deleted the humitos/pdf-binary-feature-flag branch March 18, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: work in progress Pull request is not ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants