Workaround for a django-storages bug #4963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Dec 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #4963 +/- ##
======================================
Coverage 76.8% 76.8%
======================================
Files 158 158
Lines 9937 9937
Branches 1241 1241
======================================
Hits 7632 7632
Misses 1973 1973
Partials 332 332 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4963 +/- ##
======================================
Coverage 76.8% 76.8%
======================================
Files 158 158
Lines 9937 9937
Branches 1241 1241
======================================
Hits 7632 7632
Misses 1973 1973
Partials 332 332 |
humitos
reviewed
Dec 6, 2018
| src: url('../fonts/fontawesome-webfont.eot?v=4.4.0'); | ||
| src: url('../fonts/fontawesome-webfont.eot?#iefix&v=4.4.0') format('embedded-opentype'), url('../fonts/fontawesome-webfont.woff?v=4.4.0') format('woff'), url('../fonts/fontawesome-webfont.ttf?v=4.4.0') format('truetype'), url('../fonts/fontawesome-webfont.svg?v=4.4.0#fontawesomeregular') format('svg'); | ||
| src: url('../fonts/fontawesome-webfont.eot'); | ||
| src: url('../fonts/fontawesome-webfont.eot?#iefix') format('embedded-opentype'), url('../fonts/fontawesome-webfont.woff') format('woff'), url('../fonts/fontawesome-webfont.ttf') format('truetype'), url('../fonts/fontawesome-webfont.svg') format('svg'); |
There was a problem hiding this comment.
This URL still has a ? on it. Isn't that a problem?
There was a problem hiding this comment.
No. Hashes seem to get handled properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django-storages has a bug in the AzureStorage that has problems with
?and=in URLs. This gets triggered when these files are post-processed with Django's ManifestFilesMixin