Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: use the sphinx-rtd-theme with support for addons integration #11279

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 15, 2024

Installs a version of our theme from a pull request that has support for the Addons integration using the CustomEvent.

Note

We need to enable Addons on our project for this to work properly, so the .js file is injected via Cloudflare.

Rendered version at 📚 https://docs--11279.org.readthedocs.build/en/11279/

Related: readthedocs/sphinx_rtd_theme#1526
Requires: #11205

Installs a version of our theme from a pull request that has support for the
Addons integration using the `CustomEvent`.

Related: readthedocs/sphinx_rtd_theme#1526
Requires: #11205
@humitos humitos force-pushed the humitos/docs-addons-custom-event branch from c3dd88b to fb57c40 Compare April 16, 2024 12:47
@humitos humitos marked this pull request as ready for review April 16, 2024 12:59
@humitos humitos requested review from a team as code owners April 16, 2024 12:59
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay, though I imagine we are going to wait to merge this until the theme PR is a little closer.

@humitos
Copy link
Member Author

humitos commented Apr 16, 2024

He, yeap, I'm working on that 😄 -- readthedocs/sphinx_rtd_theme#1526 (comment)

@humitos humitos merged commit 32ad910 into main Apr 18, 2024
7 checks passed
@humitos humitos deleted the humitos/docs-addons-custom-event branch April 18, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants