Canonical URL: don't set it if is empty #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #82 Ref #83 We need to release the extension first, make sure all builds are using that version and then release readthedocs/readthedocs.org#7540
ericholscher
approved these changes
Oct 6, 2020
| {%- else %} | ||
| {%- set ending = "/" if builder == "readthedocsdirhtml" else ".html" %} | ||
| {%- set canonical_page = pagename + ending %} | ||
| {%- if canonical_url %} |
There was a problem hiding this comment.
Do we want to check for and not html_baseurl? Seems that would output 2x canonical URL still.
There was a problem hiding this comment.
We are doing that check in readthedocs/readthedocs.org#7540.
We could do the check here again, but seems redundant
There was a problem hiding this comment.
we could also do all the checks here, but by doing it in .org we can set the value in html_baseurl and rely on sphinx itself to set the canonical url instead of us doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #82
Ref #83
We need to release the extension first, make sure all builds are using
that version and then release readthedocs/readthedocs.org#7540