Add Pull Request builds page to settings #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a basic form for now, but we can spruce it up before it goes live.
agjohnson
approved these changes
Aug 23, 2023
readthedocsext/theme/templates/projects/project_pull_requests.html
Outdated
Show resolved
Hide resolved
readthedocsext/theme/templates/projects/project_pull_requests.html
Outdated
Show resolved
Hide resolved
readthedocsext/theme/templates/projects/project_pull_requests.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Anthony <aj@ohess.org>
|
@agjohnson Thanks for your review 🎉. I don't think I'll push this any further this week before I head out, so feel free to merge it if you have time to clean things up for the beta 👍 |
|
Sounds good, I'll merge this when the underlying PR goes in. I can help this out if it needs anything. |
agjohnson
reviewed
Apr 10, 2024
Comment on lines
+23
to
+25
| <p> | ||
| <input class="ui button primary" type="submit" value="{% trans "Update" %}"> | ||
| </p> |
There was a problem hiding this comment.
The p element is extraneous and can be dropped. This is another spot to disable the form visually/functionally.
Suggested change
| <p> | |
| <input class="ui button primary" type="submit" value="{% trans "Update" %}"> | |
| </p> | |
| <input class="ui {% if form.errors and form.is_disabled %}disabled{% endif %} primary button" type="submit" value="{% trans "Update" %}"> |
Noted to come back to this in:
| {% endblocktrans %} | ||
| </p> | ||
|
|
||
| <form class="ui form" method="post" action="."> |
There was a problem hiding this comment.
Suggested change
| <form class="ui form" method="post" action="."> | |
| <form class="ui form" method="post" action="." {% if form.errors and form.is_disabled %}inert{% endif %}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic form for now,
but we can spruce it up before it goes live.
Depends on readthedocs/readthedocs.org#10656