Add support for niche targeting #865
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for setting a threshold of distance, so flights outside of that distance are not shown. This has a few limitations, but could be a good first step for testing out a niche targeted flight, and see what it's CTR looks like.
davidfischer
requested changes
Apr 11, 2024
There was a problem hiding this comment.
I think the INSTALLED_APPS check should be in the constructor. We can store a niche_weights=None in the constructor and only fill it out if there's any candidate flights with niche_targeting. We want to avoid doing this unless there's flights using the targeting. I'm really worried about this ballooning our time to ad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for setting a threshold of distance,
so flights outside of that distance are not shown.
This has a few limitations,
but could be a good first step for testing out a niche targeted flight,
and see what it's CTR looks like.