Dependencies: update node-sass #148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a test to try installing it via `npm` ``` npm install https://github.com/readthedocs/ethical-ad-client\#humitos/node-sass ```
agjohnson
added a commit
that referenced
this pull request
Mar 13, 2023
|
I thought this would be fine, but I found in adding CI tests here that the sass-loader version doesn't like this. However, modern sass-loader is written for webpack 5, and so there are two upgrades there that we'll need to make -- neither are huge, just more than I can tackle ATM. I proposed a different option in #149 -- drop node-sass entirely for Dart sass, which is compiled to pure JS. No more node-gyp! |
|
I borrowed some ideas from b9e834d#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
CI is added and passing now, in #149 |
We need to distinguish whether or not run this code, depending if it's imported as a module or via `<script>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a test to try installing it via
npm