Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: oclif #962

Draft
wants to merge 112 commits into
base: next
Choose a base branch
from
Draft

feat: oclif #962

wants to merge 112 commits into from

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Jan 11, 2024 •
edited

🧰 Changes

Outstanding tasks:

  • Test coverage around hooks (namely the prerun hook and the --key flag handling)
  • Issues mocking certain functions
  • Getting a build working for GitHub Actions runners

Non-blocking outstanding tasks:

  • Consolidate styling on outputs
    • Debug outputs
    • Error outputs
    • Warning outputs
    • Info outputs
    • General log outputs
  • Eliminate JSON import assertions
  • Use this.userAgent in readmeAPIFetch calls
  • Use oclif readme to autogenerate arg docs
  • Do a pass at summary/description fields for all args

🧬 QA & Testing

npm ci && npm run build
bin/run.js

@kanadgupta
chore: install base deps
855b72f
@kanadgupta
chore: rename cmds/index.ts
725683b 
i think this is causing clashes with oclif — plus we may not need it anymore?
@kanadgupta
chore: base bin scripts
d533ac4
@kanadgupta
refactor: use src/ as root
fa4045e
@kanadgupta
chore: add config
1f8c422
@kanadgupta
chore: remove eslint rule
abf41a5
@kanadgupta
feat: first pass at base class
22151e4 
- recreate base command auth + flags in oclif
@kanadgupta
feat: migrate open command to oclif
f0784e3
@kanadgupta
feat: migrate whoami to oclif
137b047
@kanadgupta
feat(oclif): logout
c16f7c5
@kanadgupta
feat(oclif): login
9106fb6
@kanadgupta
chore(deps): bump to vitest 1.x
8a49273
@kanadgupta
Merge branch 'vitest-1' into oclif
2a52998
@kanadgupta
fix: return command output in wrapper
1dfac0a 
this is probably where should do some error handling too but not sure how yet
@kanadgupta
refactor: try some fancy base class stuff
713fd5f
@kanadgupta
refactor: use vite stub
48d01df
@kanadgupta
revert: don't add error handling here yet
161a810 
this was causing errors in tests, will have to tackle this a different way
@kanadgupta
test: use oclif config for running commands
1b64116
@kanadgupta
feat: first pass at createGHA hook
c2ee0ea
@kanadgupta
fix: prerun hook quirks in tests
fde53d6
@kanadgupta
feat: openapi:validate command to oclif
5857d4d
@kanadgupta
feat: openapi:reduce + oclif
1cadce0
@kanadgupta
feat: openapi:inspect + oclif
e58dab3
@kanadgupta
refactor: use simpler signature for running createGHA
bde84e6
@kanadgupta
fix: use stored config value for apiKey properly
3617f74
@kanadgupta
feat: changelogs to oclif
1a6897b
@kanadgupta
fix(openapi/reduce): fix up some flags + debug
55e431b
@kanadgupta
Merge branch 'next' into oclif
42b6326
@kanadgupta
fix: oops
1e78a7b
@kanadgupta
feat: openapi:convert to oclif
5f06164
@kanadgupta
chore: fix link in comment
8dc9dde
@kanadgupta
feat: oclif-friendly help screen
99819a9
@kanadgupta
docs: various smol updates
8155657
@kanadgupta
chore: rip test coverage
da96609
@kanadgupta
chore: backfill helpClass oops
c9d0ea7
@kanadgupta
chore: point to right bin script oops
f5a74da
@kanadgupta
chore: files in favor of npmignore
1ddf2ec
@kanadgupta
chore: gitignore tmp
d8ea26a
@kanadgupta
chore: backfill plugins and topics oops
cf3bf59
@kanadgupta
chore: delete index.test.js, add test todos in hooks
bbdfbd8
@kanadgupta
chore: remove vi.useFakeTimers()
f01cbd8 
this is weird (and maybe it's a vitest 1.0 thing?) but basically faketimers were causing the GHA onboarding e2e tests to fail. when reading the docs, we probably didn't need it anyways since the `vi.useFakeTimers()` call isn't required for the `vi.setSystemTime` calls to work
@kanadgupta
chore: remove mock that evidently is redundant
0063c02
@kanadgupta
chore: remove unnecessary baseUrl tsconfig option
2b14476 
i think this is now taken care of with rootDir, and also it was maybe making it slightly more annoying to set import paths in vscode? plus the docs say we shouldn't use it outside of AMD module loaders

https://www.typescriptlang.org/tsconfig#baseUrl
@kanadgupta kanadgupta added the enhancement New feature or request label Jan 11, 2024
@readmeio readmeio deleted a comment from notion-workspace bot Feb 27, 2024
@kanadgupta kanadgupta mentioned this pull request May 7, 2024
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kanadgupta