feat: tables #874
Merged
feat: tables #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
force-pushed
the
feat/tables
branch
from
417dec7
to
a5f219b
Compare
kellyjosephprice
force-pushed
the
feat/tables
branch
from
a5f219b
to
c13d997
Compare
kellyjosephprice
commented
May 8, 2024
| .use(remarkMdx) | ||
| .data({ toMarkdownExtensions: [{ extensions: [compilers] }] }) | ||
| .stringify(tree, opts); | ||
| return remark().use(remarkMdx).use(remarkGfm).use(compilers).stringify(tree, opts); |
There was a problem hiding this comment.
@jennspencer just found out the way I was configuring custom compilers wouldn't override existing ones.
jennspencer
reviewed
May 8, 2024
errors/mdx-syntax-error.ts
Outdated
| const { message, line, column, url } = error; | ||
|
|
||
| const messages = [ | ||
| `Uh oh! We ran into a syntax error at { line: ${line}, column: ${column} }, please see this url for more details: ${url}`, |
jennspencer
reviewed
May 9, 2024
docs/tables.md
Outdated
| .markdown-body .rdmd-table th { | ||
| } | ||
| .markdown-body .rdmd-table td { | ||
| } | ||
| ``` | ||
|
|
||
| <style> |
There was a problem hiding this comment.
doesn't look like acorn is a big fan of this <style> tag:
but haaaay nice error messaging!
There was a problem hiding this comment.
It's not so much the script, but css. I imagine that MDX looked at trying to detect and parse css, and just table flipped
jennspencer
approved these changes
May 10, 2024
|
This PR was released!🚀 Changes included in v6.75.0-beta.30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
MDX Tables!
I also took the opportunity to start an MDX components doc, and more excitingly, a nicer compilation error!
✅ TODO
After poking at this a bunch, I think we should punt on doing feature detection. It seems best that that be done as a singular after we get everything else working.
🧬 QA & Testing