Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use PAT to avoid rate limits and update build environment #68

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

clue
Copy link
Member

@clue clue commented Feb 9, 2024

This changeset updates the build script to use a PAT secret to avoid secondary rate limits and updates the build environment. Each PAT has a rate limit of 5000 requests/h while the GITHUB_TOKEN has a rate limit of 1000 requests/h (https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#primary-rate-limit-for-github_token-in-github-actions).

I've already assigned a read-only PAT for the @reactphp-bot user for this repository. This secret should be available to the build script after this PR is merged. This means that the PR may currently fail to build, but should work regardless once merged. I've assigned the same PAT to my fork to confirm this works as expected. Once merged, the build should now work again and finally deploy all releases published since #67 was reported.

Resolves / closes #67
Builds on top of #53 and #65

@WyriHaximus WyriHaximus merged commit 0e29f8c into reactphp:main Feb 9, 2024
1 check failed
@clue clue deleted the build branch February 10, 2024 15:27
@clue
Copy link
Member Author

clue commented Feb 10, 2024

Confirmed to work by restarting the build for the merge commit, the website now builds successfully again. Not sure why the merge commit didn't pass originally, but we'll keep an eye on this until we get to improve the build process to no longer run into any rate limiting issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website build running into rate limitings
2 participants