Fix drain event of ThroughStream to handle potential race condition
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
force-pushed
the
drain-throughstream
branch
from
d6accb8
to
873679e
Compare
SimonFrings
approved these changes
Sep 25, 2023
clue
force-pushed
the
drain-throughstream
branch
from
873679e
to
6273e35
Compare
WyriHaximus
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes a potential race condition that may happen for the
drainevent ofThroughStream. This is more of an edge case when pausing/resuming/closing immediately after flushing any buffers and is unlikely to have significant impact on existing code out in the wild.The changes look relatively simple, most of the work went into making sure this is fully covered by additional tests for such edge cases. The test suite confirms this does not affect any of the existing behavior, so this should be safe to apply.