New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to upgrade phpunit for php 7.2 #132
Comments
Thanks for reporting! Can you show the output of sebastianbergmann/phpunit#2472 suggests this should be omitted with PHPUnit 5.7.11 |
It seems though that even 5.7.11 only suppresses the notice but does not fix the root cause. This will likely break the tests again once PHP >7.2 has been released and |
It will take some more years for PHP 8.0 to be released. At that point, support for PHP 5.x can probably be dropped. See https://wiki.php.net/rfc/deprecations_php_7_2#each |
@andig can you confirm that using PHPUnit 5.7.11 fixes this issue? Also, do you see the same issue with the latest PHPUnit ^4.8? Can we even give a consistent |
5.7.11 works (the failures are ok), latest 4.8.36 still has the
|
@andig Thanks for the confirmation! This means we're in a situation where we can't reliably target a minimum required PHPUnit version across all out supported PHP versions. We would have to use Given that this only applies to our It's my understanding that this issue is resolved now that you've run |
Remaining confusion is that I'm stuck with 4.8 when installing from git clone, but that might be a composer or local issue:
This happens even after cleaning
|
@andig This looks strange and can not be reproduced locally. Have you verified your |
wtf closing for own stupidity :/ |
Heh, no worries, these kind of things happen :-) Thanks for confirming back and glad this has been resolved for you 👍 |
Starting to see these notices:
The text was updated successfully, but these errors were encountered: